Sentry Supabase Integration #2913
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
==========================================
+ Coverage 86.56% 88.32% +1.75%
==========================================
Files 193 282 +89
Lines 6364 9668 +3304
==========================================
+ Hits 5509 8539 +3030
- Misses 855 1129 +274 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eca355d | 485.50 ms | 569.85 ms | 84.35 ms |
| 6f47800 | 451.04 ms | 509.64 ms | 58.60 ms |
| 2cf9161 | 454.12 ms | 512.67 ms | 58.55 ms |
| cc4e375 | 426.15 ms | 482.34 ms | 56.19 ms |
| 793f4dc | 462.68 ms | 544.21 ms | 81.53 ms |
| b6c8720 | 457.41 ms | 519.04 ms | 61.63 ms |
| 3615e19 | 468.38 ms | 504.71 ms | 36.33 ms |
| 575ebaa | 478.00 ms | 585.76 ms | 107.76 ms |
| 2d34233 | 470.54 ms | 558.90 ms | 88.36 ms |
| 9b99523 | 456.91 ms | 490.55 ms | 33.64 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eca355d | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 6f47800 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 2cf9161 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| cc4e375 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 793f4dc | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| b6c8720 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 3615e19 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 575ebaa | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 2d34233 | 6.54 MiB | 7.55 MiB | 1.01 MiB |
| 9b99523 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
Previous results on branch: feat/supabase
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d2f4fd9 | 453.31 ms | 507.02 ms | 53.71 ms |
| 0a08454 | 515.10 ms | 634.67 ms | 119.57 ms |
| 8bd9497 | 470.21 ms | 524.26 ms | 54.05 ms |
| 77c7ea9 | 447.20 ms | 497.53 ms | 50.33 ms |
| 0ab2edd | 459.85 ms | 506.63 ms | 46.77 ms |
| e4d1bf6 | 499.64 ms | 528.47 ms | 28.82 ms |
| 34b0923 | 509.55 ms | 590.18 ms | 80.62 ms |
| 30c089b | 471.71 ms | 522.65 ms | 50.94 ms |
| 5e3ca91 | 451.24 ms | 496.74 ms | 45.50 ms |
| 6a8651f | 476.65 ms | 532.62 ms | 55.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d2f4fd9 | 6.54 MiB | 7.53 MiB | 1017.45 KiB |
| 0a08454 | 6.44 MiB | 7.43 MiB | 1013.22 KiB |
| 8bd9497 | 6.44 MiB | 7.43 MiB | 1013.21 KiB |
| 77c7ea9 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 0ab2edd | 6.54 MiB | 7.53 MiB | 1016.33 KiB |
| e4d1bf6 | 6.44 MiB | 7.44 MiB | 1017.53 KiB |
| 34b0923 | 6.44 MiB | 7.43 MiB | 1013.10 KiB |
| 30c089b | 6.44 MiB | 7.43 MiB | 1010.46 KiB |
| 5e3ca91 | 6.44 MiB | 7.44 MiB | 1017.53 KiB |
| 6a8651f | 6.54 MiB | 7.53 MiB | 1015.94 KiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dbd526b | 1244.78 ms | 1259.02 ms | 14.24 ms |
| 640ad0c | 1241.04 ms | 1253.96 ms | 12.92 ms |
| 7cfbbd6 | 1270.63 ms | 1285.36 ms | 14.72 ms |
| 0fb45d0 | 1273.24 ms | 1286.44 ms | 13.19 ms |
| 6ba4675 | 1223.12 ms | 1238.17 ms | 15.04 ms |
| 575ebaa | 1262.20 ms | 1274.24 ms | 12.04 ms |
| f761369 | 1261.69 ms | 1277.82 ms | 16.12 ms |
| 2cf9161 | 1248.33 ms | 1266.55 ms | 18.22 ms |
| 73dca78 | 1246.65 ms | 1265.42 ms | 18.76 ms |
| 4481076 | 1256.48 ms | 1266.64 ms | 10.17 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dbd526b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 640ad0c | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 7cfbbd6 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 0fb45d0 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 6ba4675 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 575ebaa | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| f761369 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 2cf9161 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 73dca78 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 4481076 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
Previous results on branch: feat/supabase
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0ab2edd | 1254.71 ms | 1264.28 ms | 9.56 ms |
| 6a8651f | 1254.15 ms | 1266.88 ms | 12.73 ms |
| d2f4fd9 | 1252.60 ms | 1271.13 ms | 18.52 ms |
| 77c7ea9 | 1264.57 ms | 1279.47 ms | 14.89 ms |
| 8bd9497 | 1265.35 ms | 1273.98 ms | 8.63 ms |
| 5e3ca91 | 1263.90 ms | 1277.43 ms | 13.53 ms |
| 34b0923 | 1269.29 ms | 1275.88 ms | 6.59 ms |
| 0a08454 | 1265.15 ms | 1283.18 ms | 18.04 ms |
| e4d1bf6 | 1249.16 ms | 1267.12 ms | 17.96 ms |
| 30c089b | 1257.23 ms | 1269.16 ms | 11.93 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0ab2edd | 7.85 MiB | 9.45 MiB | 1.59 MiB |
| 6a8651f | 7.85 MiB | 9.42 MiB | 1.57 MiB |
| d2f4fd9 | 7.86 MiB | 9.45 MiB | 1.59 MiB |
| 77c7ea9 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 8bd9497 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| 5e3ca91 | 8.43 MiB | 10.00 MiB | 1.56 MiB |
| 34b0923 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| 0a08454 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| e4d1bf6 | 8.43 MiB | 10.00 MiB | 1.56 MiB |
| 30c089b | 8.43 MiB | 10.01 MiB | 1.58 MiB |
|
Will make another review pass soon |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@denrase pls take a look at cursor's comment I think the concern is valid since we'd be doing this for every request |
|
@buenaflor 🤦♂️ |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
# Conflicts: # .craft.yml # packages/flutter/example/pubspec_overrides.yaml
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Supabase instrumentation for database operations (no auth instrumentation)
💡 Motivation and Context
Closes #2727
💚 How did you test it?
Unit tests.
📝 Checklist
sendDefaultPiiis enabled