-
-
Notifications
You must be signed in to change notification settings - Fork 276
Sentry Supabase Integration #2913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
==========================================
+ Coverage 88.22% 88.34% +0.11%
==========================================
Files 294 294
Lines 10209 10209
==========================================
+ Hits 9007 9019 +12
+ Misses 1202 1190 -12 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3615e19 | 468.38 ms | 504.71 ms | 36.33 ms |
8541716 | 437.14 ms | 443.65 ms | 6.51 ms |
de377fd | 572.35 ms | 589.21 ms | 16.87 ms |
6ba4675 | 499.80 ms | 632.43 ms | 132.63 ms |
4298701 | 524.40 ms | 633.30 ms | 108.90 ms |
8825ed8 | 447.65 ms | 456.90 ms | 9.25 ms |
c8596a6 | 474.00 ms | 492.96 ms | 18.96 ms |
eca355d | 485.50 ms | 569.85 ms | 84.35 ms |
b6c8720 | 457.41 ms | 519.04 ms | 61.63 ms |
944b773 | 470.54 ms | 480.18 ms | 9.64 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3615e19 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
8541716 | 13.93 MiB | 15.00 MiB | 1.06 MiB |
de377fd | 6.54 MiB | 7.71 MiB | 1.17 MiB |
6ba4675 | 6.54 MiB | 7.53 MiB | 1015.26 KiB |
4298701 | 6.54 MiB | 7.71 MiB | 1.17 MiB |
8825ed8 | 13.93 MiB | 14.93 MiB | 1.00 MiB |
c8596a6 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
eca355d | 6.54 MiB | 7.70 MiB | 1.16 MiB |
b6c8720 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
944b773 | 13.93 MiB | 15.00 MiB | 1.06 MiB |
Previous results on branch: feat/supabase
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1476f86 | 477.10 ms | 480.87 ms | 3.77 ms |
34b0923 | 509.55 ms | 590.18 ms | 80.62 ms |
2db18e6 | 470.42 ms | 473.86 ms | 3.43 ms |
8bd9497 | 470.21 ms | 524.26 ms | 54.05 ms |
6a8651f | 476.65 ms | 532.62 ms | 55.96 ms |
b0f288d | 462.92 ms | 452.48 ms | -10.44 ms |
ecfbb1d | 479.15 ms | 537.30 ms | 58.15 ms |
77c7ea9 | 447.20 ms | 497.53 ms | 50.33 ms |
5454931 | 447.86 ms | 439.08 ms | -8.78 ms |
0ab2edd | 459.85 ms | 506.63 ms | 46.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1476f86 | 13.93 MiB | 14.93 MiB | 1.00 MiB |
34b0923 | 6.44 MiB | 7.43 MiB | 1013.10 KiB |
2db18e6 | 13.93 MiB | 14.93 MiB | 1.00 MiB |
8bd9497 | 6.44 MiB | 7.43 MiB | 1013.21 KiB |
6a8651f | 6.54 MiB | 7.53 MiB | 1015.94 KiB |
b0f288d | 13.93 MiB | 15.00 MiB | 1.06 MiB |
ecfbb1d | 6.54 MiB | 7.71 MiB | 1.17 MiB |
77c7ea9 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
5454931 | 13.93 MiB | 15.00 MiB | 1.06 MiB |
0ab2edd | 6.54 MiB | 7.53 MiB | 1016.33 KiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
827bf09 | 1261.86 ms | 1276.41 ms | 14.55 ms |
6bcdc99 | 1257.16 ms | 1264.96 ms | 7.79 ms |
0fb3800 | 1256.60 ms | 1266.28 ms | 9.68 ms |
cf443d2 | 1255.79 ms | 1248.38 ms | -7.40 ms |
81f83eb | 1259.53 ms | 1273.39 ms | 13.86 ms |
73a3c38 | 1263.37 ms | 1277.90 ms | 14.53 ms |
54acf91 | 1257.65 ms | 1277.96 ms | 20.31 ms |
a10aff4 | 1241.67 ms | 1255.02 ms | 13.35 ms |
32914d8 | 1275.47 ms | 1285.20 ms | 9.73 ms |
7b21e8b | 1256.79 ms | 1267.12 ms | 10.33 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
827bf09 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
6bcdc99 | 5.53 MiB | 6.00 MiB | 479.95 KiB |
0fb3800 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
cf443d2 | 5.53 MiB | 6.00 MiB | 479.99 KiB |
81f83eb | 7.86 MiB | 9.44 MiB | 1.58 MiB |
73a3c38 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
54acf91 | 20.70 MiB | 22.46 MiB | 1.75 MiB |
a10aff4 | 5.53 MiB | 6.00 MiB | 486.71 KiB |
32914d8 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
7b21e8b | 5.53 MiB | 6.00 MiB | 479.96 KiB |
Previous results on branch: feat/supabase
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
34b0923 | 1269.29 ms | 1275.88 ms | 6.59 ms |
5454931 | 1266.92 ms | 1270.20 ms | 3.29 ms |
d2f4fd9 | 1252.60 ms | 1271.13 ms | 18.52 ms |
f8ec07b | 1259.06 ms | 1273.22 ms | 14.16 ms |
e4d1bf6 | 1249.16 ms | 1267.12 ms | 17.96 ms |
77c7ea9 | 1264.57 ms | 1279.47 ms | 14.89 ms |
0a08454 | 1265.15 ms | 1283.18 ms | 18.04 ms |
b0f288d | 1261.51 ms | 1264.02 ms | 2.51 ms |
0ab2edd | 1254.71 ms | 1264.28 ms | 9.56 ms |
6a8651f | 1254.15 ms | 1266.88 ms | 12.73 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
34b0923 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
5454931 | 5.53 MiB | 6.00 MiB | 479.95 KiB |
d2f4fd9 | 7.86 MiB | 9.45 MiB | 1.59 MiB |
f8ec07b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
e4d1bf6 | 8.43 MiB | 10.00 MiB | 1.56 MiB |
77c7ea9 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
0a08454 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
b0f288d | 5.53 MiB | 6.00 MiB | 479.95 KiB |
0ab2edd | 7.85 MiB | 9.45 MiB | 1.59 MiB |
6a8651f | 7.85 MiB | 9.42 MiB | 1.57 MiB |
@denrase could you have a look at cursor comments pls |
@buenaflor Issues should be addressed now. |
} | ||
span.setData('db.operation', supabaseRequest.operation.value); | ||
span.setData('db.sql.query', supabaseRequest.generateSqlQuery()); | ||
span.setData('db.system', 'postgres'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
span.setData('db.system', 'postgres'); | |
span.setData('db.system', 'postgresql'); |
final dbSchema = supabaseRequest.request.headers['Accept-Profile'] ?? | ||
supabaseRequest.request.headers['Content-Profile']; | ||
if (dbSchema != null) { | ||
span.setData('db.schema', dbSchema); | ||
} | ||
span.setData('db.table', supabaseRequest.table); | ||
span.setData('db.url', supabaseRequest.request.url.origin); | ||
final dbSdk = supabaseRequest.request.headers['X-Client-Info']; | ||
if (dbSdk != null) { | ||
span.setData('db.sdk', dbSdk); | ||
} | ||
// ignore: invalid_use_of_internal_member | ||
if (supabaseRequest.query.isNotEmpty && _hub.options.sendDefaultPii) { | ||
span.setData('db.query', supabaseRequest.query); | ||
} | ||
// ignore: invalid_use_of_internal_member | ||
if (supabaseRequest.body != null && _hub.options.sendDefaultPii) { | ||
span.setData('db.body', supabaseRequest.body); | ||
} | ||
span.setData('db.operation', supabaseRequest.operation.value); | ||
span.setData('db.sql.query', supabaseRequest.generateSqlQuery()); | ||
span.setData('db.system', 'postgres'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can put all these constant span data key/values into the constants.dart
file within SentrySpanData
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can make use of this constants file also for the other constants used in this PR
📜 Description
Supabase instrumentation for database operations (no auth instrumentation)
💡 Motivation and Context
Closes #2727
💚 How did you test it?
Unit tests.
📝 Checklist
sendDefaultPii
is enabled